linux-kernel - Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250331120040.75d0577e@jic23-huawei>
Date: Mon, 31 Mar 2025 12:00:40 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Zhang Lixu <lixu.zhang@...el.com>
Cc: linux-iio@...r.kernel.org, lars@...afoo.de, jikos@...nel.org,
 srinivas.pandruvada@...ux.intel.com, peterz@...radead.org,
 gregkh@...uxfoundation.org, ribalda@...omium.org,
 archana.patni@...ux.intel.com, linux-kernel@...r.kernel.org,
 linux-input@...r.kernel.org, even.xu@...el.com
Subject: Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET
 calculation

On Mon, 31 Mar 2025 13:50:19 +0800
Zhang Lixu <lixu.zhang@...el.com> wrote:

> This patch series addresses issues in the hid-sensor-prox driver related to
> SCALE and OFFSET calculations. The changes include restoring lost scale
> assignments, supporting multi-channel SCALE calculation, and fixing incorrect
> OFFSET calculation.
> 
Hi.

Generally I prefer to see review tags (Srinivas' Acks here) given on list
but in I trust Srinivas to have done a thorough review (or to shout when he
sees this!) and the changes look correct to me, applied to the fixes-togreg-testing
branch of iio.git.

Odd point in merge cycle hence the odd temporary branch.

Jonathan

> 
> Zhang Lixu (3):
>   iio: hid-sensor-prox: Restore lost scale assignments
>   iio: hid-sensor-prox: support multi-channel SCALE calculation
>   iio: hid-sensor-prox: Fix incorrect OFFSET calculation
> 
>  .../hid-sensors/hid-sensor-attributes.c       |  4 ++++
>  drivers/iio/light/hid-sensor-prox.c           | 22 ++++++++++++-------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 
> 
> base-commit: e21edb1638e82460f126a6e49bcdd958d452929c