linux-kernel - Re: [PATCH] interconnect: Add NULL check in exynos_generic_icc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f8a3f75-f66f-4380-ae60-b84f6752da0b@kernel.org>
Date: Mon, 31 Mar 2025 13:32:30 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Henry Martin <bsdhenrymartin@...il.com>, djakov@...nel.org
Cc: s.nawrocki@...sung.com, a.swigon@...sung.com, alim.akhtar@...sung.com,
 linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] interconnect: Add NULL check in exynos_generic_icc_probe

On 31/03/2025 13:08, Henry Martin wrote:
> When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function exynos_generic_icc_probe.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


> 
> A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error. 



> This is similar to the commit 050b23d081da.

Not related. These are different drivers, so drop.

These apply to all your patches.


Best regards,
Krzysztof