linux-kernel - Re: [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76836050-a701-4d6e-859e-8aed23d234a2@kernel.org>
Date: Mon, 31 Mar 2025 13:40:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Henry Martin <bsdhenrymartin@...il.com>, joel@....id.au,
 andrew@...econstruct.com.au
Cc: herve.codina@...tlin.com, gsomlo@...il.com, heiko@...ech.de,
 andersson@...nel.org, u.kleine-koenig@...libre.com,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/misc: Add NULL check in aspeed_lpc_enable_snoop

On 31/03/2025 11:39, Henry Martin wrote:
> When devm_kasprintf() fails, it returns a NULL pointer. However, this return value is not properly checked in the function aspeed_lpc_enable_snoop.
> 
> A NULL check should be added after the devm_kasprintf() to prevent potential NULL pointer dereference error.
> 

Same comments.

> Fixes: 3772e5da44542 ("Aspeed LPC snoop output using misc chardev")
> 

There is never a blank line between tags.

> Signed-off-by: Henry Martin <bsdhenrymartin@...il.com>
> ---
>  drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> index 9ab5ba9cf1d6..376b3a910797 100644
> --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
> +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
> @@ -200,6 +200,8 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
>  	lpc_snoop->chan[channel].miscdev.minor = MISC_DYNAMIC_MINOR;
>  	lpc_snoop->chan[channel].miscdev.name =
>  		devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, channel);
> +	if (!lpc_snoop->chan[channel].miscdev.name)
> +		return -ENOMEM;

Missing cleanup.

Best regards,
Krzysztof