linux-kernel - Re: [PATCH net v1] net: Fix tuntap uninitialized value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPpAL=y2ysE6jJgVYAOOx9DQXOYkR627LF1nusb2-Jwx6gXR8A@mail.gmail.com>
Date: Mon, 31 Mar 2025 19:47:16 +0800
From: Lei Yang <leiyang@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jiayuan Chen <jiayuan.chen@...ux.dev>, 
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, netdev@...r.kernel.org, 
	jasowang@...hat.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net, 
	hawk@...nel.org, john.fastabend@...il.com, linux-kernel@...r.kernel.org, 
	syzbot+0e6ddb1ef80986bdfe64@...kaller.appspotmail.com, bpf@...r.kernel.org, 
	martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org, kpsingh@...nel.org, 
	jolsa@...nel.org
Subject: Re: [PATCH net v1] net: Fix tuntap uninitialized value

QE tested this patch with virtio-net regression tests, everything works fine.

Tested-by: Lei Yang <leiyang@...hat.com>


On Fri, Mar 28, 2025 at 7:39 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri, 28 Mar 2025 09:15:53 +0000 Jiayuan Chen wrote:
> > I'm wondering if we can directly perform a memset in bpf_xdp_adjust_head
> > when users execute an expand header (offset < 0).
>
> Same situation happens in bpf_xdp_adjust_meta(), but I'm pretty
> sure this was discussed and considered too high cost for XDP.
> Could you find the old discussions and double check the arguments
> made back then? Opinions may have changed but let's make sure we're
> not missing anything. And performance numbers would be good to have
> since the main reason this isn't done today was perf.
>