linux-kernel - Re: [PATCH 4/4] arm64: dts: renesas: r8a779g3: Add Renesas R-Car V4H Sparrow Hawk board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734eu11ul.wl-kuninori.morimoto.gx@renesas.com>
Date: Mon, 31 Mar 2025 00:27:15 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: linux-arm-kernel@...ts.infradead.org,	Krzysztof Wilczyński <kw@...ux.com>,	Rafał Miłecki
 <rafal@...ecki.pl>,	Aradhya Bhatia <a-bhatia1@...com>,	Bjorn Helgaas
 <bhelgaas@...gle.com>,	Conor Dooley <conor+dt@...nel.org>,	Geert
 Uytterhoeven <geert+renesas@...der.be>,	Heiko Stuebner <heiko@...ech.de>,
	Junhao Xie <bigfoot@...ssfun.cn>,	Kever Yang <kever.yang@...k-chips.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,	Lorenzo Pieralisi
 <lpieralisi@...nel.org>,	Magnus Damm <magnus.damm@...il.com>,	Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>,	Neil Armstrong
 <neil.armstrong@...aro.org>,	Rob Herring <robh@...nel.org>,	Yoshihiro
 Shimoda <yoshihiro.shimoda.uh@...esas.com>,	devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,	linux-pci@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: renesas: r8a779g3: Add Renesas R-Car V4H Sparrow Hawk board support


Hi Marek

Thank you for the patch

> Add Renesas R-Car V4H Sparrow Hawk board based on R-Car V4H ES3.0 (R8A779G3)
> SoC. This is a single-board computer with single gigabit ethernet, DSI-to-eDP
> bridge, DSI and two CSI2 interfaces, audio codec, two CANFD ports, micro SD
> card slot, USB PD supply, USB 3.0 ports, M.2 Key-M slot for NVMe SSD, debug
> UART and JTAG.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>

Not all parts, but for my related part only

Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

One concern from my side is

> +	/* Page 31 / FAN */
> +	fan: pwm-fan {
> +		pinctrl-0 = <&irq4_pins>;
> +		pinctrl-names = "default";
> +		compatible = "pwm-fan";
> +		#cooling-cells = <2>;
> +		cooling-levels = <0 50 100 150 200 255>;
> +		pwms = <&pwm0 0 50000>;
> +		pulses-per-revolution = <2>;
> +		interrupts-extended = <&intc_ex 4 IRQ_TYPE_EDGE_FALLING>;
> +		/* No FAN connected by default. */
> +		status = "disabled";
> +	};

Indeed "base kit" doesn't have FAN, but "complete kit" will have, and
official page/site will recommend to buy and use it because the board will
be very hot. Default "enable" is better idea, IMO.
But it is not a big deal for now. Additional patch instead of v2 is OK for me.

Thank you for your help !!

Best regards
---
Kuninori Morimoto