[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87semt493w.fsf@kernel.org>
Date: Mon, 31 Mar 2025 15:34:27 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Benno
Lossin" <benno.lossin@...ton.me>, "Alice Ryhl" <aliceryhl@...gle.com>,
"Masahiro Yamada" <masahiroy@...nel.org>, "Nathan Chancellor"
<nathan@...nel.org>, "Nicolas Schier" <nicolas@...sle.eu>, "Luis
Chamberlain" <mcgrof@...nel.org>, "Danilo Krummrich" <dakr@...nel.org>,
"Trevor Gross" <tmgross@...ch.edu>, "Adam Bratschi-Kaye"
<ark.email@...il.com>, <rust-for-linux@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-kbuild@...r.kernel.org>, "Petr
Pavlu" <petr.pavlu@...e.com>, "Sami Tolvanen" <samitolvanen@...gle.com>,
"Daniel Gomez" <da.gomez@...sung.com>, "Simona Vetter"
<simona.vetter@...ll.ch>, "Greg KH" <gregkh@...uxfoundation.org>, "Fiona
Behrens" <me@...enk.dev>, "Daniel Almeida"
<daniel.almeida@...labora.com>, <linux-modules@...r.kernel.org>
Subject: Re: [PATCH v9 1/3] rust: str: add radix prefixed integer parsing
functions
"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:
> On Fri, Mar 21, 2025 at 10:18 AM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>>
>> Add the trait `ParseInt` for parsing string representations of integers
>> where the string representations are optionally prefixed by a radix
>> specifier. Implement the trait for the primitive integer types.
>>
>> Tested-by: Daniel Almeida <daniel.almeida@...labora.com>
>> Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>
> I had applied the following comments in v8 when I originally took it
> before discovering the UB -- since this patch may finally go through
> modules (or not), Andreas asked me to put them here:
>
> [ Added integer type suffixes to `assert!`s for consistency with the
> others. Changed links to docs.kernel.org. Applied Markdown and
> intra-doc links where possible. Changed to `///` for `mod` docs.
> Slightly reworded comment. Pluralized section name. Hid
> `use`s. Removed `#[expect]` for the `rusttest` target. - Miguel ]
>
> Attached range diff of what I did.
>
> I hope that helps!
Thanks Miguel!
I will add the diff to the next spin.
Best regards,
Andreas Hindborg
Powered by blists - more mailing lists