linux-kernel - Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28dd049e-65b1-4111-8a24-ba9765bbb1f6@linaro.org>
Date: Mon, 31 Mar 2025 14:40:51 +0100
From: James Clark <james.clark@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Suzuki K Poulose <suzuki.poulose@....com>
Cc: Mike Leach <mike.leach@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct
 fwnode_handle forward declaration



On 31/03/2025 8:14 am, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Since the code wants to use the pointer to the struct fwnode_handle
> the forward declaration is provided.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/hwtracing/coresight/coresight-cti.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h
> index 16e310e7e9d4..8362a47c939c 100644
> --- a/drivers/hwtracing/coresight/coresight-cti.h
> +++ b/drivers/hwtracing/coresight/coresight-cti.h
> @@ -9,7 +9,6 @@
>   
>   #include <linux/coresight.h>
>   #include <linux/device.h>
> -#include <linux/fwnode.h>
>   #include <linux/list.h>
>   #include <linux/spinlock.h>
>   #include <linux/sysfs.h>
> @@ -17,6 +16,8 @@
>   
>   #include "coresight-priv.h"
>   
> +struct fwnode_handle;
> +
>   /*
>    * Device registers
>    * 0x000 - 0x144: CTI programming and status

Reviewed-by: James Clark <james.clark@...aro.org>