linux-kernel - Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3876f271-b13d-414b-800d-c9a3bae5a436@ti.com>
Date: Mon, 31 Mar 2025 09:04:21 +0300
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Abdun Nihaal <abdun.nihaal@...il.com>, <kvalo@...nel.org>
CC: <linville@...driver.com>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wifi: wl1251: fix memory leak in wl1251_tx_work

On 3/30/2025 1:45 PM, Abdun Nihaal wrote:
> The skb dequeued from tx_queue is lost when wl1251_ps_elp_wakeup fails
> with a -ETIMEDOUT error. Fix that by queueing the skb back to tx_queue.
> 
> Fixes: c5483b719363 ("wl12xx: check if elp wakeup failed")
> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com
Reviewed-by: Michael Nemanov <michael.nemanov@...com>