linux-kernel - Re: Re: [PATCH] ARM: Fix support for CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-qyLY-Moj5Uo8XH@shell.armlinux.org.uk>
Date: Mon, 31 Mar 2025 16:18:05 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Maxim Uvarov <muvarov@...il.com>
Cc: 谢致邦 (XIE Zhibang) <Yeking@...54.com>,
	ardb@...nel.org, bjorn.andersson@...yericsson.com,
	dave@...ilevsky.ca, ebiggers@...gle.com, linus.walleij@...aro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	liuyuntao12@...wei.com, lumag@...nel.org, masahiroy@...nel.org,
	nathan@...nel.org, nico@...xnic.net, oskar.andero@...yericsson.com,
	ruanjinjie@...wei.com, victor.boivie@...yericsson.com,
	Rob Herring <robh@...nel.org>
Subject: Re: Re: [PATCH] ARM: Fix support for CMDLINE_EXTEND

On Mon, Mar 31, 2025 at 06:14:27PM +0300, Maxim Uvarov wrote:
> It will be good  to have some constance here with other arches:
> ./arch/arm/kernel/atags_parse.c:#if defined(CONFIG_CMDLINE_EXTEND)
> ./arch/sh/kernel/setup.c:#ifdef CONFIG_CMDLINE_EXTEND
> ./arch/powerpc/kernel/prom_init.c:    if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) || l <= 0 || p[0] == '\0')
> ./arch/loongarch/kernel/setup.c:     * CONFIG_CMDLINE_EXTEND is enabled.
> ./arch/loongarch/kernel/setup.c:    if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) && CONFIG_CMDLINE[0]) {
> ./arch/riscv/kernel/pi/cmdline_early.c:    if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
> 
> Or drop CONFIG_CMDLINE_EXTEND completely or make arm64 work as others.

I'm not changing something that has had 14 years of being the way it's
been - people will have come to rely upon it. Changing it now is way
too late.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!