linux-kernel - Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UbUqNf4WoWzqMe5bDQmxiT+bRG_cn0n1dBrkFRijx0Cw@mail.gmail.com>
Date: Mon, 31 Mar 2025 08:06:36 -0700
From: Doug Anderson <dianders@...omium.org>
To: Tejas Vipin <tejasvipin76@...il.com>
Cc: neil.armstrong@...aro.org, maarten.lankhorst@...ux.intel.com, 
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch, 
	quic_jesszhan@...cinc.com, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, asrivats@...hat.com
Subject: Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi
 wrapped functions

Hi,

On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin <tejasvipin76@...il.com> wrote:
>
> @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel *panel)
>
>         ret = boe_bf060y8m_aj0_on(boe);
>         if (ret < 0) {
> -               dev_err(dev, "Failed to initialize panel: %d\n", ret);
>                 gpiod_set_value_cansleep(boe->reset_gpio, 1);
>                 return ret;

It's not new, but the error handling here looks wrong to me. Instead
of just returning after setting the GPIO, this should be turning off
the regulators, shouldn't it? That would mean adding a new error label
for turning off "BF060Y8M_VREG_VCI" and then jumping to that.

Given that we're already squeezing an error handling fix into this
patch, maybe it would make sense to add this one too (and, of course,
mention it in the commit message).

-Doug