linux-kernel - [PATCH net] net: pcs: lynx: fix phylink validation regression for phy-mode = "10g-qxgmii"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250331153906.642530-1-vladimir.oltean@nxp.com>
Date: Mon, 31 Mar 2025 18:39:06 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: netdev@...r.kernel.org
Cc: Ioana Ciornei <ioana.ciornei@....com>,
	Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH net] net: pcs: lynx: fix phylink validation regression for phy-mode = "10g-qxgmii"

Added by commit ce312bbc2351 ("net: pcs: lynx: accept phy-mode =
"10g-qxgmii" and use in felix driver"), this mode broke when the
lynx_interfaces[] array was introduced to populate
lynx->pcs.supported_interfaces, because it is absent from there.

mscc_felix 0000:00:00.5: MAC returned PCS which does not support 10g-qxgmii
mscc_felix 0000:00:00.5: failed to validate link configuration for inband

In reality we should be querying the SerDes driver of the attached lane
to restrict which PHY modes are truly supported, but we currently lack
that infrastructure upstream, so just add 10g-qxgmii to the array.

Fixes: b0f88c1b9a53 ("net: pcs: lynx: fill in PCS supported_interfaces")
Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
---
 drivers/net/pcs/pcs-lynx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index c0238360eb40..07c570e2d7c1 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c
@@ -536,6 +536,7 @@ static const phy_interface_t lynx_interfaces[] = {
 	PHY_INTERFACE_MODE_2500BASEX,
 	PHY_INTERFACE_MODE_10GBASER,
 	PHY_INTERFACE_MODE_USXGMII,
+	PHY_INTERFACE_MODE_10G_QXGMII,
 };
 
 void lynx_pcs_set_supported_interfaces(struct phylink_pcs *pcs,
-- 
2.34.1