linux-kernel - [PATCH] kernfs: fix potential NULL dereference in mmap handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401151859.2842-1-vulab@iscas.ac.cn>
Date: Tue,  1 Apr 2025 23:18:59 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: gregkh@...uxfoundation.org,
	tj@...nel.org
Cc: linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] kernfs: fix potential NULL dereference in mmap handler

The kernfs_fop_mmap() invokes the '->mmap' callback without verifying its
existence. This leads to a NULL pointer dereference when the kernfs node
does not define the operation, resulting in an invalid memory access.

Add a check to ensure the '->mmap' callback is present before invocation.
Return -EINVAL when uninitialized to prevent the invalid access.

Fixes: 324a56e16e44 ("kernfs: s/sysfs_dirent/kernfs_node/ and rename its friends accordingly")
Cc: stable@...r.kernel.org # 3.14+
Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 fs/kernfs/file.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index 8502ef68459b..7d8434a97487 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -459,9 +459,14 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma)
 		goto out_unlock;
 
 	ops = kernfs_ops(of->kn);
-	rc = ops->mmap(of, vma);
-	if (rc)
+	if (ops->mmap) {
+		rc = ops->mmap(of, vma);
+		if (rc)
+			goto out_put;
+	} else {
+		rc = -EINVAL;
 		goto out_put;
+	}
 
 	/*
 	 * PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup()
-- 
2.42.0.windows.2