linux-kernel - Re: [PATCH] RDMA/mlx5: hide unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250401153613.GH186258@ziepe.ca>
Date: Tue, 1 Apr 2025 12:36:13 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Patrisious Haddad <phaddad@...dia.com>
Cc: Mark Bloch <mbloch@...dia.com>, Arnd Bergmann <arnd@...nel.org>,
	Leon Romanovsky <leon@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Tariq Toukan <tariqt@...dia.com>, Jakub Kicinski <kuba@...nel.org>,
	Moshe Shemesh <moshe@...dia.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: hide unused code

On Tue, Apr 01, 2025 at 06:20:09PM +0300, Patrisious Haddad wrote:

> > > #ifdefing away half the file seems ugly.
> agreed, which is why I think mark bloch suggestion makes more sense, do you
> think it is okay ? or you think there is issues with it ?

I think you should split the file so we get the proper level of code
elimination.

But Mark's is small and sane enough to fix the build problems.

Jason