linux-kernel - RE: [PATCH] i2c: rzv2m: Constify struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB12089EC8451B0701770BCAA72C2AC2@TY3PR01MB12089.jpnprd01.prod.outlook.com>
Date: Tue, 1 Apr 2025 15:48:27 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Andi Shyti
	<andi.shyti@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] i2c: rzv2m: Constify struct i2c_algorithm

> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Sent: 29 March 2025 14:37
> Subject: [PATCH] i2c: rzv2m: Constify struct i2c_algorithm
> 
> 'struct i2c_algorithm' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   11027	    646	     16	  11689	   2da9	drivers/i2c/busses/i2c-rzv2m.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   11107	    566	     16	  11689	   2da9	drivers/i2c/busses/i2c-rzv2m.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

> ---
> Compile tested-only.
> ---
>  drivers/i2c/busses/i2c-rzv2m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rzv2m.c b/drivers/i2c/busses/i2c-rzv2m.c
> index 53762cc56d28..b0e9c0b62429 100644
> --- a/drivers/i2c/busses/i2c-rzv2m.c
> +++ b/drivers/i2c/busses/i2c-rzv2m.c
> @@ -402,7 +402,7 @@ static const struct i2c_adapter_quirks rzv2m_i2c_quirks = {
>  	.flags = I2C_AQ_NO_ZERO_LEN,
>  };
> 
> -static struct i2c_algorithm rzv2m_i2c_algo = {
> +static const struct i2c_algorithm rzv2m_i2c_algo = {
>  	.xfer = rzv2m_i2c_xfer,
>  	.functionality = rzv2m_i2c_func,
>  };
> --
> 2.49.0