linux-kernel - Re: [git pull] drm for 6.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiP0ea7xq2P3ryYs6xGWoqTw1E4jha67ZbJkaFrjqUdkQ@mail.gmail.com>
Date: Tue, 1 Apr 2025 09:12:00 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Jason Gunthorpe <jgg@...dia.com>, Dave Airlie <airlied@...il.com>, 
	dri-devel <dri-devel@...ts.freedesktop.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm for 6.15-rc1

On Tue, 1 Apr 2025 at 05:21, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>
> The header checks have existed for uapi headers before, including the,
> uh, turds, but apparently adding them in drm broke the camel's back.

The uapi header test things never caused any problems for me [*],
because they don't actually pollute the source tree.

Why? Because they all end up in that generated 'usr/include/' directory.

So when I look at the source files, filename completion is entirely
unaffected, and it all works fine.

Look, I can complete something like

    include/uapi/asm-generic/poll.h

perfectly fine, because there is *not* some generated turd that affects it all.

Because for the uapi files those hdrtest files end up being in

    ./usr/include/asm-generic/poll.hdrtest

and I never have any reason to really look at that subdirectory at
all, since it's all generated.

Or put another way - if I _were_ to look at it, it would be exactly
because I want to see some generated file, in which case the 'hdrtest'
turd would be part of it.

(Although I cannot recall that ever having actually happened, to be
honest - but looking at various header files is common, and I hit the
drm case immediately)

Would you mind taking more of that uapi approach than creating that
hidden directory specific to the drm tree? Maybe this could *all* be
generalized?

           Linus

[*] I say "never caused any problems for me", but maybe it did way in
the past and it was fixed and I just don't recall. I have definitely
complained about pathname completion issues to people before.