[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-wj_eO6FGcwsEh6@pie.lan>
Date: Tue, 1 Apr 2025 17:35:57 +0000
From: Yao Zi <ziyao@...root.org>
To: Chukun Pan <amadeus@....edu.cn>
Cc: Rob Herring <robh@...nel.org>, Jonas Karlman <jonas@...boo.se>,
Heiko Stuebner <heiko@...ech.de>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: Add DMA controller for
RK3528
On Tue, Apr 01, 2025 at 06:00:19PM +0800, Chukun Pan wrote:
> Add DMA controller dt node for RK3528 SoC.
>
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> ---
> arch/arm64/boot/dts/rockchip/rk3528.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> index 7f1ffd6003f5..c366766ee3f5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> @@ -493,6 +493,24 @@ sdhci: mmc@...f0000 {
> status = "disabled";
> };
>
> + dmac: dma-controller@...60000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x0 0xffd60000 0x0 0x4000>;
> + clocks = <&cru ACLK_DMAC>;
> + clock-names = "apb_pclk";
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
> + arm,pl330-periph-burst;
Should this be moved above "clocks" line to sort the properties?
Thanks,
Yao Zi
> + #dma-cells = <1>;
> + };
> +
> pinctrl: pinctrl {
> compatible = "rockchip,rk3528-pinctrl";
> rockchip,grf = <&ioc_grf>;
> --
> 2.25.1
>
Powered by blists - more mailing lists