linux-kernel - Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025040127-unretired-veto-b056@gregkh>
Date: Tue, 1 Apr 2025 19:18:21 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Erick Karanja <karanja99erick@...il.com>
Cc: outreachy@...ts.linux.dev, philipp.g.hortmann@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs

On Tue, Apr 01, 2025 at 07:59:37PM +0300, Erick Karanja wrote:
> Remove spaces before tabs to comply with the Linux kernel coding style
> guidelines. Proper indentation using tabs improves code consistency
> and readability.
> 
> Reported by checkpatch:
> 
>     WARNING: please, no space before tabs
> 
> Signed-off-by: Erick Karanja <karanja99erick@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------
>  1 file changed, 6 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index 9105594d2dde..44f73baf1cb4 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -9,14 +9,14 @@
>  #include <hal_btcoex.h>
>  #include <Mp_Precomp.h>
>  
> -/* 		Global variables */
> +/*Global variables */

Does that look right?  (hint, it isn't...)

Always put a space after the /* and before text.  You removed the one
that was there already :(

thanks,

greg k-h