[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <83c02df7-25c7-44d4-a0b6-d771061dc5c5@linux.dev>
Date: Tue, 1 Apr 2025 16:12:59 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Christian Marangi <ansuelsmth@...il.com>, Rob Herring <robh@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, Philipp Zabel
<p.zabel@...gutronix.de>, Daniel Golle <daniel@...rotopia.org>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, upstream@...oha.com
Subject: Re: [net-next PATCH 4/6] dt-bindings: net: ethernet-controller:
permit to define multiple PCS
On 3/27/25 11:49, Christian Marangi wrote:
> On Fri, Mar 21, 2025 at 11:18:12AM -0500, Rob Herring wrote:
>> On Wed, Mar 19, 2025 at 12:58:40AM +0100, Christian Marangi wrote:
>> > Drop the limitation of a single PCS in pcs-handle property. Multiple PCS
>> > can be defined for an ethrnet-controller node to support various PHY
>>
>> typo
>>
>> > interface mode type.
>>
>> What limitation? It already supports multiple PCS phandles. It doesn't
>> support arg cells. If you want that, either you have to fix the number
>> of cells or define a #pcs-handle-cells property. You've done neither
>> here.
>>
>> Adding #pcs-handle-cells will also require some updates to the dtschema
>> tools.
>>
>
> I might be confused by doesn't
>
> pcs-handle:
> items:
> maxItems: 1
>
> limit it to
>
> pcs-handle = <&foo>;
>
> and make it not valid
>
> pcs-handle = <&foo1>, <&foo2>;
>
> ?
You should modify this in the MAC's devicetree. See
Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml for an
example.
> The cells property will come but only when there will be an actual user
> for it (I assume QCOM PCS will make use of it)
I think it would be better to add this as necessary.
--Sean
Powered by blists - more mailing lists