linux-kernel - Re: [PATCH] locking/local_lock, mm: Replace localtry_ helpers with local_trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+5Mv7Pjb7qQxovKuiuuwYFZ+vgEWEzJuHy63BJwPY74Q@mail.gmail.com>
Date: Tue, 1 Apr 2025 13:55:48 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, bpf <bpf@...r.kernel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Peter Zijlstra <peterz@...radead.org>, Sebastian Sewior <bigeasy@...utronix.de>, 
	Steven Rostedt <rostedt@...dmis.org>, Shakeel Butt <shakeel.butt@...ux.dev>, 
	Michal Hocko <mhocko@...e.com>, linux-mm <linux-mm@...ck.org>, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] locking/local_lock, mm: Replace localtry_ helpers with
 local_trylock_t type

On Tue, Apr 1, 2025 at 7:18 AM Vlastimil Babka <vbabka@...e.cz> wrote:
>
> > with newly introduced local_trylock_t type.
> > Note that attempt to use local_trylock_irqsave() with local_lock_t
> > will cause compilation failure.
> >
> > Usage and behavior in !PREEMPT_RT:
> >
> > local_lock_t lock;                     // sizeof(lock) == 0
>
> local_lock(&lock, ...);                 // preempt disable

changed to local_lock(&lock);

>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
>
> Is there a chance this refactoring will make it to -rc1? It would make
> basing the further usage of the lock in mm and slab trees much easier.

+1

> But squash in the following fixups please:

Thanks a bunch. Folded.

And sent v2:
https://lore.kernel.org/bpf/20250401205245.70838-1-alexei.starovoitov@gmail.com/

As soon as Sebastian acks it, I can send bpf PR with these 3 fixes
and other bpf fixes.