linux-kernel - Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07d65709cbc9e4e0fbf25da7d7e70e19aec7409d@linux.dev>
Date: Tue, 01 Apr 2025 21:37:53 +0000
From: "Yosry Ahmed" <yosry.ahmed@...ux.dev>
To: "Shakeel Butt" <shakeel.butt@...ux.dev>, "Tejun Heo" <tj@...nel.org>
Cc: "Johannes Weiner" <hannes@...xchg.org>,
 "Michal Koutný" <mkoutny@...e.com>,
 linux-mm@...ck.org, cgroups@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Meta kernel team" <kernel-team@...a.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "Breno Leitao" <leitao@...ian.org>,
 "Venkat Rao Bagalkote" <venkat88@...ux.ibm.com>
Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with
 cgroup_rstat_lock

April 1, 2025 at 7:09 PM, "Shakeel Butt" <shakeel.butt@...ux.dev> wrote:
> 
> The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and
> locking") during cleanup accidentally changed the code to call
> cgroup_rstat_updated_list() without cgroup_rstat_lock which is required. 
> Fix it.
> 
> Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking")
> Reported-by: Jakub Kicinski <kuba@...nel.org>
> Reported-by: Breno Leitao <leitao@...ian.org>
> Reported-by: Venkat Rao Bagalkote <venkat88@...ux.ibm.com>
> Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca4@linux.ibm.com/
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>

Thanks for fixing this.

Reviewed-by: Yosry Ahmed <yosry.ahmed@...ux.dev>