[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fX6FubpJeROoXa10jV8RnAD0LKS1GaAcidLzbwZgOmQXg@mail.gmail.com>
Date: Tue, 1 Apr 2025 15:05:01 -0700
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>, Howard Chu <howardchu95@...il.com>,
Weilin Wang <weilin.wang@...el.com>, Levi Yun <yeoreum.yun@....com>,
"Dr. David Alan Gilbert" <linux@...blig.org>, Andi Kleen <ak@...ux.intel.com>,
James Clark <james.clark@...aro.org>, Dominique Martinet <asmadeus@...ewreck.org>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/5] NMI warning and debug improvements
On Mon, Mar 17, 2025 at 9:14 PM Ian Rogers <irogers@...gle.com> wrote:
>
> The NMI warning wouldn't fire even if all the events were for one PMU
> type. Remove a nearby, and no longer useful, mixed hardware event
> group function. Improve the evlist to string function and dump it in
> verbose mode after the reordered events warning.
>
> As commonly happens legacy events like instructions will be uniquified
> to hybrid events like cpu_core/instructions/, even though the
> encodings differ. To make this correct either:
> https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/
> or:
> https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/
> needs merging.
>
> Ian Rogers (5):
> perf stat: Better hybrid support for the NMI watchdog warning
> perf stat: Remove print_mixed_hw_group_error
> perf evlist: Refactor evlist__scnprintf_evsels
> perf evlist: Add groups to evlist__format_evsels
> perf parse-events: Add debug dump of evlist if reordered
Ping.
Thanks,
Ian
> tools/perf/builtin-record.c | 9 ++++---
> tools/perf/util/evlist.c | 32 +++++++++++++++---------
> tools/perf/util/evlist.h | 3 ++-
> tools/perf/util/parse-events.c | 16 +++++++++---
> tools/perf/util/stat-display.c | 45 ++++++++++------------------------
> tools/perf/util/stat.h | 1 -
> 6 files changed, 55 insertions(+), 51 deletions(-)
>
> --
> 2.49.0.rc1.451.g8f38331e32-goog
>
Powered by blists - more mailing lists