linux-kernel - Re: [PATCH v5] iio: frequency: ad9832: Use FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGd6pzPe71oY=+cy3WqKPyZ150q3pOM3LrPE0_ENeKgd+OvnfQ@mail.gmail.com>
Date: Wed, 2 Apr 2025 03:45:51 +0530
From: Siddharth Menon <simeddon@...il.com>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev, gregkh@...uxfoundation.org, jic23@...nel.org, 
	Michael.Hennerich@...log.com, lars@...afoo.de
Subject: Re: [PATCH v5] iio: frequency: ad9832: Use FIELD_PREP macro to set
 bit fields

On Sun, 30 Mar 2025 at 21:13, Marcelo Schmitt
<marcelo.schmitt1@...il.com> wrote:
> The previous implementation would set ctrl_fp if val == 1 and unset it if val == 0.
> This patch seems to be doing the reverse (setting ctrl_fp if val == 0, and
> unsetting it if val != 0). Was the previous implementation potentially buggy?

My apologies, I seem to have made a mistake here.

> Hmm, this is modifying behavior. AD9832_SLEEP and AD9832_CLR were only being
> modified if something other than 0 was written to output enable sysfs file.
> Is the patch code mode appropriate than how the driver was before?

I shall address the aforementioned issues along with the ones pointed out by
Jonathan in my next patch.

Thank you for taking the time to review my patches.

Regards,
Siddharth Menon