linux-kernel - Re: [PATCH v2 2/5] staging: rtl8723bs: add spaces between ternary and binary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff964c79-6cc2-c0ed-14c8-cec02a3e95fa@inria.fr>
Date: Wed, 2 Apr 2025 00:30:19 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Erick Karanja <karanja99erick@...il.com>
cc: gregkh@...uxfoundation.org, outreachy@...ts.linux.dev, 
    philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] staging: rtl8723bs: add spaces between ternary
 and binary operators



On Tue, 1 Apr 2025, Erick Karanja wrote:

> Fix spacing around binary arithmetic (`+`) and shift (`>>`) operators
> to improve readability and adhere to the Linux kernel coding style.
>
> Reported by checkpatch:
>
> 	CHECK: spaces needed around 'operator'
>
> Signed-off-by: Erick Karanja <karanja99erick@...il.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> index 928c58be6c9b..3b43f8cfd6f4 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> @@ -155,9 +155,9 @@ void ODM_CfoTracking(void *pDM_VOID)
>  		/* 4 1.6 Big jump */
>  		if (pCfoTrack->bAdjust) {
>  			if (CFO_ave > CFO_TH_XTAL_LOW)
> -				Adjust_Xtal = Adjust_Xtal+((CFO_ave-CFO_TH_XTAL_LOW)>>2);
> +				Adjust_Xtal = Adjust_Xtal + ((CFO_ave-CFO_TH_XTAL_LOW) >> 2);

I think you have missed a - here: CFO_ave-CFO_TH_XTAL_LOW.  Likewise
below.

julia

>  			else if (CFO_ave < (-CFO_TH_XTAL_LOW))
> -				Adjust_Xtal = Adjust_Xtal+((CFO_TH_XTAL_LOW-CFO_ave)>>2);
> +				Adjust_Xtal = Adjust_Xtal + ((CFO_TH_XTAL_LOW-CFO_ave) >> 2);
>  		}
>
>  		/* 4 1.7 Adjust Crystal Cap. */
> --
> 2.43.0
>
>
>