linux-kernel - Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq creation for admin & disco ctrlrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <MN2PR04MB68629F5634238CCB432DD9FDBCAC2@MN2PR04MB6862.namprd04.prod.outlook.com>
Date: Tue, 1 Apr 2025 22:52:14 +0000
From: Kamaljit Singh <Kamaljit.Singh1@....com>
To: Niklas Cassel <cassel@...nel.org>
CC: "kbusch@...nel.org" <kbusch@...nel.org>, "axboe@...nel.dk"
	<axboe@...nel.dk>, hch <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Damien Le Moal
	<dlemoal@...nel.org>
Subject: Re: [PATCH v1 1/1] nvme: add admin controller support. prohibit ioq
 creation for admin & disco ctrlrs

Hi Niklas,

On 2025/03/31 00:25, Niklas Cassel wrote:

>Like Damien said,
>
>> Added capability to connect to an administrative controller by
>> preventing ioq creation for admin-controllers.
>
>patch 2/4,
>I think I deserve:
>Suggested-by: Niklas Cassel <cassel@...nel.org>
>
>on this patch.
You sure do. I wasn't aware of this designation. I'll add it. Thanks for
all your help.


>> * Renamed nvme_discovery_ctrl() to nvmf_discovery_ctrl() as discovery is
>>   more relevant to fabrics
>
>patch 1/4, you need to move the function, but can keep the name.
Like I replied to Damien, I wasn't able to easily move these to host/nvme.h
so they're in core.c.

I'll separate into patches as you suggested.

Thanks,
Kamaljit