linux-kernel - Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e9bf509-ebf5-4703-bab6-fb9770f975d1@intel.com>
Date: Mon, 31 Mar 2025 22:46:55 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>, "mingo@...hat.com" <mingo@...hat.com>
CC: "x86@...nel.org" <x86@...nel.org>, "Nikula, Jani" <jani.nikula@...el.com>,
	"bp@...en8.de" <bp@...en8.de>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "peterz@...radead.org" <peterz@...radead.org>,
	"hpa@...or.com" <hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "rppt@...nel.org" <rppt@...nel.org>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "jpoimboe@...nel.org"
	<jpoimboe@...nel.org>, "pmladek@...e.com" <pmladek@...e.com>, "xin@...or.com"
	<xin@...or.com>, "tglx@...utronix.de" <tglx@...utronix.de>, "Luck, Tony"
	<tony.luck@...el.com>
Subject: Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

On 3/31/2025 6:06 PM, Huang, Kai wrote:

>>> Ah I didn't know this series was merged.  I think I'll stop looking at it.  :-)
>>
>> Your review comments have been useful. Please continue reviewing if you
>> can. You found an issue in patch 1 that both of us missed.
>>
> 
> I just did.  I didn't find anything apart from one thing that I _think_ it might
> be helpful to mention another commit in the changelog of patch 5 "x86/nmi: Fix
> comment in unknown NMI handling".
> 

Kai, I feel the additional commit is indirectly implied. I am inclined
to leave the changelog as-is unless you feel strongly about it.

Thank you for the reviews. Really appreciate it!

Ingo, there are 2 main changes from the patches in tip:x86/nmi.

1) As pointed out by Kai, there is a minor oversight in patch 1 on my
part. The header files aren't strictly ordered. There needs to be a
single line change to keep them alphabetically ordered.

2) As discussed in patch 7, the title for split-off patch is incorrect.

If you prefer, I can generate a new series based on the patches you have
in tip to save you the extra effort again. Or I can generate a single
additional patch on top if you want.

OTOH, feel free to make the changes yourself and include my signoffs.