linux-kernel - Re: [PATCH v3] drivers/misc: Add NULL check in aspeed_lpc_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03d87a25-02ea-4e4a-8d3f-c2fcdc4d068e@web.de>
Date: Tue, 1 Apr 2025 09:09:08 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-aspeed@...ts.ozlabs.org,
 linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Jeffery <andrew@...econstruct.com.au>, Arnd Bergmann <arnd@...db.de>,
 Bjorn Andersson <andersson@...nel.org>,
 Herve Codina <herve.codina@...tlin.com>, Joel Stanley <joel@....id.au>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>
Subject: Re: [PATCH v3] drivers/misc: Add NULL check in
 aspeed_lpc_enable_snoop

> devm_kasprintf() return NULL if memory allocation fails. Currently,
…
                call?                               failed?

> Add NULL check after devm_kasprintf() to prevent this issue.

Do you propose to improve this function implementation a bit more?

…
> ---
> V2 -> V3: Simplify the arrary access and correct commit message.
…

* Would you like to avoid a typo here?

* I imagine that there is a need to offer such adjustments
  in separate update steps.
  https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n81

* Please choose a more appropriate subsystem specification.
  https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/soc/aspeed/aspeed-lpc-snoop.c?h=next-20250331

* How do you think about to append parentheses to a function name
  also in the summary phrase?

Regards,
Markus