linux-kernel - Re: [GIT PULL] objtool fixes and updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-ucroZoh3TgtQxA@gmail.com>
Date: Tue, 1 Apr 2025 09:58:38 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tiezhu Yang <yangtiezhu@...ngson.cn>
Subject: Re: [GIT PULL] objtool fixes and updates


* Josh Poimboeuf <jpoimboe@...nel.org> wrote:

> On Sun, Mar 30, 2025 at 06:39:51PM -0700, Josh Poimboeuf wrote:
> > On Mon, Mar 31, 2025 at 01:13:55AM +0200, Borislav Petkov wrote:
> > > On Sun, Mar 30, 2025 at 03:19:40PM -0700, Linus Torvalds wrote:
> > > > On Sat, 29 Mar 2025 at 08:33, Borislav Petkov <bp@...en8.de> wrote:
> > > > >
> > > > > Btw, test bot complains:
> > > > >
> > > > > https://lore.kernel.org/r/202503292202.Sge7ZEUc-lkp@intel.com
> > > > 
> > > > That's not a very helpful error message
> > > 
> > > I found this:
> > > 
> > > https://lore.kernel.org/r/202503280703.OARM8SrY-lkp@intel.com
> > > 
> > > which looks like the original report.
> > > 
> > > Looks unsolved yet...
> > 
> > The "new" warning is just the "skipping duplicate warning", which was
> > already merged with commit 0a7fb6f07e3a ("objtool: Increase per-function
> > WARN_FUNC() rate limit").  So none of the warnings are specific to this
> > pull request.
> > 
> > Tiezhu, can you please look at this warning?
> >   
> >    arch/loongarch/kernel/traps.o: warning: objtool: show_stack+0xe0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-160
> >    arch/loongarch/kernel/traps.o: warning: objtool: show_stack+0xe0: stack state mismatch: reg1[23]=-1+0 reg2[23]=-2-152
> 
> Here's a fix.  Will post a real fix soon, along with another pile of 
> fixes.

And just to make it clear, these objtool warnings were not a new 
regression, they were introduced more than a year ago, via:

  cb8a2ef0848c ("LoongArch: Add ORC stack unwinder support")

So, to bring this thread to a conclusion, I think by getting rid of the 
summary warning line:

  c5610071a69d ("Revert "objtool: Increase per-function WARN_FUNC() rate limit"")

... the CI test-bots ought to be back to the v6.14 baseline even taking 
such false positives into account.

I'll send the updated objtool/urgent tree to Linus later today, unless 
some last-minute problem pops up.

Thanks,

	Ingo