linux-kernel - Re: [PATCH v2] HID: uclogic: Add NULL check in uclogic_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a73250f0-8fbd-40a7-b4b6-bc45050c9289@web.de>
Date: Tue, 1 Apr 2025 10:21:02 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v2] HID: uclogic: Add NULL check in
 uclogic_input_configured

> devm_kasprintf() return NULL if memory allocation fails. Currently,
…
                call?                               failed?

> Add NULL check after devm_kasprintf() to prevent this issue.

Do you propose to improve this function implementation a bit more?

…
> ---
> V1 -> V2:
> Simplify the handing of the condition "suffix" with if/else suggested by …

* I imagine that there is a need to offer such adjustments
  in separate update steps.
  https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n81

* Can another tag become more helpful?
  https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n598

> The current implementation (directly returning -ENOMEM) is reasonable because:
…

How much will such information influence the refinement of the change description?

How do you think about to append parentheses to a function name
also in the summary phrase?

Regards,
Markus