[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z-um5bWEjfmH5XHT@tiehlicka>
Date: Tue, 1 Apr 2025 10:42:13 +0200
From: Michal Hocko <mhocko@...e.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, bpf@...r.kernel.org,
daniel@...earbox.net, andrii@...nel.org, martin.lau@...nel.org,
akpm@...ux-foundation.org, peterz@...radead.org, vbabka@...e.cz,
bigeasy@...utronix.de, rostedt@...dmis.org, shakeel.butt@...ux.dev,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc: Fix try_alloc_pages
On Mon 31-03-25 20:23:36, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@...nel.org>
>
> Fix an obvious bug. try_alloc_pages() should set_page_refcounted.
>
> Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
Acked-by: Michal Hocko <mhocko@...e.com>
> ---
>
> As soon as I fast forwarded and rerun the tests the bug was
> seen immediately.
> I'm completely baffled how I managed to lose this hunk.
> I'm pretty sure I manually tested various code paths of
> trylock logic with CONFIG_DEBUG_VM=y.
> Pure incompetence :(
I believe Vlastimil is right. This seems to be an unfortunate mismatch
in the final tree when this got merged.
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists