linux-kernel - Re: [PATCH] serial: lantiq: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5166661-3e51-46c9-b675-e0ec973ea5a7@quicinc.com>
Date: Tue, 1 Apr 2025 14:20:35 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Chen Ni <nichen@...as.ac.cn>, <gregkh@...uxfoundation.org>,
        <jirislaby@...nel.org>, <u.kleine-koenig@...libre.com>
CC: <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: lantiq: Remove unnecessary print function
 dev_err()



On 4/1/2025 1:33 PM, Chen Ni wrote:
> Function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
> ---
>   drivers/tty/serial/lantiq.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
> index 58a3ab030d67..62cd9e0bb377 100644
> --- a/drivers/tty/serial/lantiq.c
> +++ b/drivers/tty/serial/lantiq.c
> @@ -773,10 +773,8 @@ static int fetch_irq_intel(struct device *dev, struct ltq_uart_port *ltq_port)
>   	int ret;
>   
>   	ret = platform_get_irq(to_platform_device(dev), 0);
> -	if (ret < 0) {
> -		dev_err(dev, "failed to fetch IRQ for serial port\n");
> +	if (ret < 0)
>   		return ret;
> -	}
>   	ltq_port->common_irq = ret;
>   	port->irq = ret;
>