linux-kernel - Re: [PATCH 6/9] x86/nmi: Improve and relocate NMI handler comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebe40381df4306a6cf772f868d4980d7ada1767b.camel@intel.com>
Date: Tue, 1 Apr 2025 01:03:02 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "x86@...nel.org"
	<x86@...nel.org>
CC: "Nikula, Jani" <jani.nikula@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"peterz@...radead.org" <peterz@...radead.org>, "hpa@...or.com"
	<hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "rppt@...nel.org" <rppt@...nel.org>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>, "jpoimboe@...nel.org"
	<jpoimboe@...nel.org>, "pmladek@...e.com" <pmladek@...e.com>, "xin@...or.com"
	<xin@...or.com>, "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [PATCH 6/9] x86/nmi: Improve and relocate NMI handler comments

On Thu, 2025-03-27 at 23:46 +0000, Mehta, Sohil wrote:
> Some of the comments in the default NMI handling code are out of place
> or inadequate. Move them to the appropriate locations and update them as
> needed.
> 
> Move the comment related to CPU-specific NMIs closer to the actual code.
> Also, add more details about how back-to-back NMIs are detected since
> that isn't immediately obvious.
> 
> Opportunistically, replace an #ifdef section in the vicinity with an
> IS_ENABLED() check to make the code easier to read.
> 
> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>

Acked-by: Kai Huang <kai.huang@...el.com>