[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bf3ff4a5-e8e0-4d25-b878-1ee2308befcc@web.de>
Date: Tue, 1 Apr 2025 12:14:04 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Henry Martin <bsdhenrymartin@...il.com>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
Benjamin Tissoires <bentiss@...nel.org>, Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v3] HID: uclogic: Add NULL check in
uclogic_input_configured()
> devm_kasprintf() return NULL if memory allocation fails. Currently,
…
call? failed?
> Add NULL check after devm_kasprintf() to prevent this issue.
Do you propose to improve this function implementation a bit more?
…
> ---
> V2 -> V3: Kept the original switch structure, only optimized the outer
> conditional checks while maintaining safety requirements.
> V1 -> V2: Simplify the handing of the condition "suffix" with if/else.
* Under which circumstances will you begin to care more to offer such adjustments
in separate update steps?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n81
* Can another tag become more helpful?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n598
Can an other control flow variant be a bit nicer finally?
if (suffix) {
…
} else {
…
}
Regards,
Markus
Powered by blists - more mailing lists