linux-kernel - Re: [PATCH v1 4/6] dt-bindings: arm: qcom: Add Asus Zenbook A14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMcHhXoxLx9SiUcntp1vmmK7BF0SO_uo3DCBx_3Ldd3tx+rBXg@mail.gmail.com>
Date: Tue, 1 Apr 2025 12:16:55 +0200
From: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Dmitry Baryshkov <lumag@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Abel Vesa <abel.vesa@...aro.org>, 
	Johan Hovold <johan+linaro@...nel.org>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-usb@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v1 4/6] dt-bindings: arm: qcom: Add Asus Zenbook A14

On Tue, 1 Apr 2025 at 07:38, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 31/03/2025 23:53, Aleksandrs Vinarskis wrote:
> > Document the X1E-78-100 and X1P-42-100/X1-26-100 variants.
> >
> > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 08c329b1e919..1b7e2ed56baa 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -1133,6 +1133,7 @@ properties:
> >        - items:
> >            - enum:
> >                - asus,vivobook-s15
> > +              - asus,x1e80100-zenbook-a14
>
> asus,zenbook-a14-x1e80100
>
> asus did not make a component of x1e80100 soc.

I see, I misunderstood the meaning of qcom,x1e80100-crd, clear now.
In that case, perhaps follow pattern of other devices, describe by
model differences (eg. -oled) instead of soc? eg:

`asus,zenbook-a14-ux3407ra` (for x1e variant)
`asus,zenbook-a14-ux3407qa` (for x1/x1p variants)

Thanks for the review,
Alex

>
> >                - dell,xps13-9345
> >                - hp,omnibook-x14
> >                - lenovo,yoga-slim7x
> > @@ -1144,6 +1145,7 @@ properties:
> >
> >        - items:
> >            - enum:
> > +              - asus,x1p42100-zenbook-a14
>
> Same here.
>
>
> Best regards,
> Krzysztof