[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <707db3e3-b380-4db4-96e9-50e66b0be595@oss.qualcomm.com>
Date: Tue, 1 Apr 2025 12:27:55 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Johan Hovold <johan+linaro@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Jens Glathe <jens.glathe@...schoolsolutions.biz>,
Abel Vesa <abel.vesa@...aro.org>,
Stephan Gerhold <stephan.gerhold@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-hp-x14: drop bogus USB retimer
On 3/28/25 9:41 AM, Johan Hovold wrote:
> Jens reported that the sanity checks added to the new ps883x USB retimer
> driver breaks USB and display on the HP X14. Turns out the X14 only has
> a retimer on one of the ports, but this initially went unnoticed due to
> the missing sanity check (and error handling) in the retimer driver.
>
> Drop the non-existing retimer from the devicetree to enable the second
> USB port and the display subsystem.
>
> Note that this also matches the ACPI tables.
>
> Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
> Cc: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>
> The devicetree went upstream before the retimer driver so the display
> would already be broken in 6.14 and there's no need to backport this
> one (but it should go into 6.15).
>
> Note that the SBU mux can be added later when/if someone figures out how
> it is connected.
I am shocked, but this product photo [1] (is this the right laptop? there's a
bunch with similar naming) on the HP website suggests that indeed only one port
has a USB-40Gbps marking on it, with the other type-C only being supposed to do
10Gbps
Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Konrad
[1] https://ssl-product-images.www8-hp.com/digmedialib/prodimg/lowres/c08993265.png
Powered by blists - more mailing lists