linux-kernel - Re: [PATCH 1/2] block: allow setting partition of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67eb43c1.050a0220.142b98.3224@mx.google.com>
Date: Tue, 1 Apr 2025 03:39:09 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Jens Axboe <axboe@...nel.dk>, Al Viro <viro@...iv.linux.org.uk>,
	Douglas Anderson <dianders@...gle.com>,
	Christian Brauner <brauner@...nel.org>,
	Riyan Dhiman <riyandhiman14@...il.com>,
	Konstantin Khlebnikov <koct9i@...il.com>,
	Li Lingfeng <lilingfeng3@...wei.com>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] block: allow setting partition of_node

On Tue, Mar 04, 2025 at 05:06:01PM +0000, Daniel Golle wrote:
> Allow partition parsers to set the Device Tree node for a partition by
> introducing of_put_partition() and extending struct parsed_partitions
> accordingly.
> 
> As the partition information is preallocated independently of the actual
> number of partitions the additional pointer takes about 2 kiB of allocated
> memory which is worth avoiding in case CONFIG_OF is not set. This is
> achieved by only adding the corresponding field to the struct in case
> CONFIG_OF is set using #ifdef'ery.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

I also think ifdef for OF is a necessity in this case to prevent the struct
size to explode.

Reviewed-by: Christian Marangi <ansuelsmth@...il.com>

-- 
	Ansuel