linux-kernel - Re: [PATCH v3] platform/x86: thinkpad_acpi: disable ACPI fan access for T495* and E560

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174350731915.2494.4458891330469738526.b4-ty@linux.intel.com>
Date: Tue, 01 Apr 2025 14:35:19 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: hmh@....eng.br, hdegoede@...hat.com, 
 Seyediman Seyedarab <imandevel@...il.com>
Cc: ibm-acpi-devel@...ts.sourceforge.net, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Seyediman Seyedarab <ImanDevel@...il.com>, 
 Vlastimil Holer <vlastimil.holer@...il.com>, stable@...r.kernel.org, 
 Alireza Elikahi <scr0lll0ck1s4b0v3h0m3k3y@...il.com>, 
 Kurt Borja <kuurtb@...il.com>, 
 Eduard Christian Dumitrescu <eduard.c.dumitrescu@...il.com>
Subject: Re: [PATCH v3] platform/x86: thinkpad_acpi: disable ACPI fan
 access for T495* and E560

On Mon, 24 Mar 2025 11:24:42 -0400, Seyediman Seyedarab wrote:

> T495, T495s, and E560 laptops have the FANG+FANW ACPI methods (therefore
> fang_handle and fanw_handle are not NULL) but they do not actually work,
> which results in a "No such device or address" error. The DSDT table code
> for the FANG+FANW methods doesn't seem to do anything special regarding
> the fan being secondary. Fan access and control is restored after forcing
> the legacy non-ACPI fan control method by setting both fang_handle and
> fanw_handle to NULL. The bug was introduced in commit 57d0557dfa49
> ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support"),
> which added a new fan control method via the FANG+FANW ACPI methods.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: disable ACPI fan access for T495* and E560
      commit: 2b9f84e7dc863afd63357b867cea246aeedda036

--
 i.