linux-kernel - Re: [PATCH v11 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+_ehUxO+oJaO0CC2BCr=ydmjpXE1hngxW8b926NG+io5HvEBQ@mail.gmail.com>
Date: Tue, 1 Apr 2025 13:48:25 +0200
From: "Christian Marangi (Ansuel)" <ansuelsmth@...il.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Antoine Tenart <atenart@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>, 
	Boqun Feng <boqun.feng@...il.com>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, linux-crypto@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, upstream@...oha.com, 
	Richard van Schagen <vschagen@...oud.com>
Subject: Re: [PATCH v11 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto
 engine support

Il giorno mar 1 apr 2025 alle ore 13:33 Herbert Xu
<herbert@...dor.apana.org.au> ha scritto:
>
> On Tue, Apr 01, 2025 at 01:20:44PM +0200, Christian Marangi (Ansuel) wrote:
> >
> > Sorry but isn't it enough to acquire lock before eip93_put_descriptor to
> > prevent 2 thread?
>
> It would be, but where is the lock? In the other places where the
> same function is used you take the ring write lock.  But not here
> in the hash function.
>

Oh god! You are right, now I'm noticing... The scoped guard is missing!

Let me quickly send a fix-up patch!