linux-kernel - RE: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock Enclave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM9PR04MB86041AD6FCC870CB8B7CBB4C95AC2@AM9PR04MB8604.eurprd04.prod.outlook.com>
Date: Tue, 1 Apr 2025 11:51:04 +0000
From: Pankaj Gupta <pankaj.gupta@....com>
To: Frank Li <frank.li@....com>
CC: Jonathan Corbet <corbet@....net>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v14 4/6] firmware: imx: add driver for NXP EdgeLock
 Enclave

>> diff --git a/drivers/firmware/imx/ele_base_msg.c
...
>> +			rx_msg->header.size -= 2;
>> +
>> +			if (rx_msg->header.size > 4)
>> +				rx_msg->header.size--;
>> +
>> +			for (i = 0; i < rx_msg->header.size; i += 2)
>> +				dev_info(priv->dev, "%s%02x_%02x: 0x%08x
0x%08x",
>> +					 FW_DBG_DUMP_FIXED_STR,	msg_ex_cnt,
i,
>> +					 rx_msg->data[i + 1], rx_msg->data[i
+ 2]);

> According to common sense, most likely it is rx_msg->data[i + 0],
rx_msg->data[i + 1].
> rx_msg->data[0] have special means?

Yes, rx_msg->data[0] have special means, that it to share the FW's response
code.

>> +		} else {
>> +			dev_err(priv->dev, "Dump_Debug_Buffer Error: %x.",
ret);
>> +			break;
>> +		}
>> +		msg_ex_cnt++;
>> +	} while (keep_logging);
>> +
>> +	return ret;

Download attachment "smime.p7s" of type "application/pkcs7-signature" (11094 bytes)