linux-kernel - Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in clkname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <017349ed-d1fd-418e-90ca-a7113cafd025@kernel.org>
Date: Tue, 1 Apr 2025 14:52:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: shao.mingyin@....com.cn, alim.akhtar@...sung.com
Cc: yang.yang29@....com.cn, xu.xin16@....com.cn, ye.xingchen@....com.cn,
 gregkh@...uxfoundation.org, jirislaby@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 jiang.peng9@....com.cn
Subject: Re: [PATCH] tty: serial: samsung: Fix potential buffer overflow in
 clkname

On 01/04/2025 13:24, shao.mingyin@....com.cn wrote:
> From: Peng Jiang <jiang.peng9@....com.cn>
> 
> Compiling the kernel with gcc12.3 W=1 produces a warning:
> /drivers/tty/serial/samsung_tty.c: In function
> 's3c24xx_serial_set_termios':
> 
> /drivers/tty/serial/samsung_tty.c:1392:48:
> warning: '%d' directive writing between 1 and 3 bytes
> into a region of size 2 [-Wformat-overflow=]
>  1392 |  sprintf(clkname, "clk_uart_baud%d", cnt);

Same comments as with other patches, not possible, IMO. Plus this patch
looks actually worse - commit msg is hardly readable.

Best regards,
Krzysztof