[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <37B638D3-969F-4834-9948-22FCFFEEF62E@collabora.com>
Date: Tue, 1 Apr 2025 10:01:01 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>,
Boris-Chengbiao Zhou <bobo1239@....de>,
Kees Cook <kees@...nel.org>,
Fiona Behrens <me@...enk.dev>,
rust-for-linux@...r.kernel.org,
linux-kernel@...r.kernel.org,
Lukas Wirth <lukas.wirth@...rous-systems.com>
Subject: Re: [PATCH v5 06/13] scripts: generate_rust_analyzer.py: add type
hints
Hi Tamir,
>>
>> I found `args_crates_cfgs()` a lot easier to understand, but I guess this is a
>> matter of taste. I also find that this `defaultdict()` call slightly pollutes
>> the surrounding code, but again, that might be just me.
>
> Would extracting a local variable suffice?
>
Yeah, that would make it less crowded.
— Daniel
Powered by blists - more mailing lists