linux-kernel - Re: [PATCH 2/2] media: atomisp: Fix Wformat-truncation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfVa5QYW9Srx1aDBFuvBp5OcWr1bnNUdhf6rJx_NemEqw@mail.gmail.com>
Date: Tue, 1 Apr 2025 16:03:58 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Hans Verkuil <hverkuil@...all.nl>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Hans de Goede <hdegoede@...hat.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Andy Shevchenko <andy@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH 2/2] media: atomisp: Fix Wformat-truncation warning

On Mon, Mar 31, 2025 at 7:38 PM Ricardo Ribalda <ribalda@...omium.org> wrote:
>
> Gcc8 is convinced that we do not have enough space in dot_id_input_bin.
> Extend the variable 17 bytes. It is just used for debugging.
>
> drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:1336:9: warning: '(pipe' directive output may be truncated writing 5 bytes into a region of size between 1 and 74 [-Wformat-truncation=]

...

> -static char dot_id_input_bin[SH_CSS_MAX_BINARY_NAME + 10];
> +static char dot_id_input_bin[SH_CSS_MAX_BINARY_NAME + 27];

I'm okay with the approach, but can you also add a comment to explain
27, please?
(I mean something like "27 is the combined length of 'pipe' plus ...")

-- 
With Best Regards,
Andy Shevchenko