linux-kernel - [PATCH v1] arcnet: Add NULL check in com20020pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250401134903.28462-1-bsdhenrymartin@gmail.com>
Date: Tue,  1 Apr 2025 21:49:03 +0800
From: Henry Martin <bsdhenrymartin@...il.com>
To: m.grzeschik@...gutronix.de,
	andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com
Cc: netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Henry Martin <bsdhenrymartin@...il.com>
Subject: [PATCH v1] arcnet: Add NULL check in com20020pci_probe()

devm_kasprintf() returns NULL when memory allocation fails. Currently,
com20020pci_probe() does not check for this case, which results in a
NULL pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: 6b17a597fc2f ("arcnet: restoring support for multiple Sohard Arcnet cards")
Signed-off-by: Henry Martin <bsdhenrymartin@...il.com>
---
 drivers/net/arcnet/com20020-pci.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c
index c5e571ec94c9..65c6fab0e359 100644
--- a/drivers/net/arcnet/com20020-pci.c
+++ b/drivers/net/arcnet/com20020-pci.c
@@ -264,6 +264,13 @@ static int com20020pci_probe(struct pci_dev *pdev,
 							"pci:red:recon:%d-%d",
 							dev->dev_id, i);
 			card->recon_led.dev = &dev->dev;
+			if (!card->tx_led.default_trigger ||
+			    !card->tx_led.name ||
+			    !card->recon_led.default_trigger ||
+			    !card->recon_led.name) {
+				ret = -ENOMEM;
+				goto err_free_arcdev;
+			}
 
 			ret = devm_led_classdev_register(&pdev->dev, &card->tx_led);
 			if (ret)
-- 
2.34.1