linux-kernel - Re: [PATCH 1/1] misc: pci_endpoint_test: Set .driver_data for PCI_DEVICE_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z+vwfHOLIej1gjsL@lizhi-Precision-Tower-5810>
Date: Tue, 1 Apr 2025 09:56:12 -0400
From: Frank Li <Frank.li@....com>
To: Niklas Cassel <cassel@...nel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
	"open list:PCI ENDPOINT SUBSYSTEM" <linux-pci@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] misc: pci_endpoint_test: Set .driver_data for
 PCI_DEVICE_ID_IMX8

On Tue, Apr 01, 2025 at 12:29:19PM +0200, Niklas Cassel wrote:
> On Tue, Apr 01, 2025 at 12:05:37PM +0200, Niklas Cassel wrote:
> >
> > But... I suggest that we just remove the pci_endpoint_test_alloc_irq_vectors()
> > call from pci_endpoint_test_probe().
>
> ...
>
> Solution 1.
>
>
> >
> > Or, if we want to keep allocating some kind of IRQ vector in probe(),
> > just to rule out totally broken platforms, I guess we could also do:
>
> ...
>
> Solution 2.
>
>
>
> Considering that this is a test driver, I actually think Solution 1 is better.
> That way, even if the platform has issues with IRQs, the user can do still do
> all the tests/ioctls() that do not require working IRQs, e.g. PCITEST_BAR and
> PCITEST_BARS.

Can you post patch directly, so I can test it.

Frank

>
>
> Kind regards,
> Niklas