linux-kernel - Re: [PATCH v2 10/12] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cbd404a-856a-4bc3-ab76-eeb839065a2d@paulmck-laptop>
Date: Tue, 1 Apr 2025 07:05:11 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Joe Perches <joe@...ches.com>
Cc: rcu@...r.kernel.org, Joel Fernandes <joelagnelf@...dia.com>,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	rostedt@...dmis.org
Subject: Re: [PATCH v2 10/12] checkpatch: Deprecate srcu_read_lock_lite() and
 srcu_read_unlock_lite()

On Mon, Mar 31, 2025 at 11:53:25PM -0700, Joe Perches wrote:
> On Mon, 2025-03-31 at 14:03 -0700, Paul E. McKenney wrote:
> > Uses of srcu_read_lock_lite() and srcu_read_unlock_lite() are better
> > served by the new srcu_read_lock_fast() and srcu_read_unlock_fast() APIs.
> > As in srcu_read_lock_lite() and srcu_read_unlock_lite() would never have
> > happened had I thought a bit harder a few months ago.  Therefore, mark
> > them deprecated.
> 
> Would it be better to convert the 3 existing instances?

Both are needed.  The point of these checkpatch.pl changes is to prevent
other instances from being added.

							Thanx, Paul

> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > ---
> >  scripts/checkpatch.pl | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 7b28ad3317427..de8ed5efc5b16 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -838,6 +838,8 @@ our %deprecated_apis = (
> >  	"kunmap"				=> "kunmap_local",
> >  	"kmap_atomic"				=> "kmap_local_page",
> >  	"kunmap_atomic"				=> "kunmap_local",
> > +	"srcu_read_lock_lite"			=> "srcu_read_lock_fast",
> > +	"srcu_read_unlock_lite"			=> "srcu_read_unlock_fast",
> >  );
> >  
> >  #Create a search pattern for all these strings to speed up a loop below
> 
>