linux-kernel - Re: [PATCH -v2 00/49] Simplify, reorganize and clean up the x86 text-patching code (alternative.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250401143115.GG5880@noisy.programming.kicks-ass.net>
Date: Tue, 1 Apr 2025 16:31:15 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Juergen Gross <jgross@...e.com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH -v2 00/49] Simplify, reorganize and clean up the x86
 text-patching code (alternative.c)

On Fri, Mar 28, 2025 at 02:26:15PM +0100, Ingo Molnar wrote:
> This series has 3 main parts:
> 
> (1)
> 
> The first part of this series performs a thorough text-patching API namespace
> cleanup discussed with Linus for the -v1 series:
> 
> 	# boot/UP APIs & single-thread helpers:
> 
> 						text_poke()
> 						text_poke_kgdb()
> 	[ unchanged APIs: ]			text_poke_copy()
> 						text_poke_copy_locked()
> 						text_poke_set()
> 
> 						text_poke_addr()
> 
> 	# SMP API & helpers namespace:
> 
> 	text_poke_bp()			=>	smp_text_poke_single()
> 	text_poke_loc_init()		=>	__smp_text_poke_batch_add()
> 	text_poke_queue()		=>	smp_text_poke_batch_add()
> 	text_poke_finish()		=>	smp_text_poke_batch_finish()
> 
> 	text_poke_flush()		=>	[removed]
> 
> 	text_poke_bp_batch()		=>	smp_text_poke_batch_process()
> 	poke_int3_handler()		=>	smp_text_poke_int3_trap_handler()
>         text_poke_sync()		=>	smp_text_poke_sync_each_cpu()
> 

Not sure I like that; smp_text_poke_ is a bit of a mouth full, esp. if
you're then adding even more text.

Do we really need function names this long?