[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87ecycrko4.fsf@bootlin.com>
Date: Tue, 01 Apr 2025 17:00:43 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Alexander Usyskin <alexander.usyskin@...el.com>
Cc: Richard Weinberger <richard@....at>, Vignesh Raghavendra
<vigneshr@...com>, Lucas De Marchi <lucas.demarchi@...el.com>, Thomas
Hellström <thomas.hellstrom@...ux.intel.com>, Rodrigo
Vivi
<rodrigo.vivi@...el.com>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
<airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Jani Nikula
<jani.nikula@...ux.intel.com>, Joonas Lahtinen
<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
Karthik Poosa <karthik.poosa@...el.com>, Reuven Abliyev
<reuven.abliyev@...el.com>, Oren Weil <oren.jer.weil@...el.com>,
linux-mtd@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 01/12] mtd: core: always create master device
Hello Alexander,
On 26/03/2025 at 17:26:12 +02, Alexander Usyskin <alexander.usyskin@...el.com> wrote:
> Create master device without partition when
> CONFIG_MTD_PARTITIONED_MASTER flag is unset.
>
> This streamlines device tree and allows to anchor
> runtime power management on master device in all cases.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
I successfully tested it, this patch will be applied at -rc1 to the
mtd/next tree.
I was wondering, do you think it would be possible to keep the creation
of mtd_master and make it a symbolic link to mtdx when
MTD_PARTITIONED_MASTER=y or when there is no partition? In short, always
having mtd_masterx, because I fear at some point we'll have problems
otherwise :-)
Right now we have:
- Without partition:
mtd0 (mtd0ro mtdblock0)
- With partition and MTD_PARTITIONED_MASTER=n
mtd0 (mtd0ro mtdblock0)
mtd_master0
- With partition and MTD_PARTITIONED_MASTER=y
mtd0 (mtd0ro mtdblock0) [this is the master]
mtd1 (mtd1ro mtdblock1)
I am suggesting:
- Without partition:
mtd0 (mtd0ro mtdblock0)
mtd_master0 -> link to mtd0
- With partition and MTD_PARTITIONED_MASTER=n
mtd0 (mtd0ro mtdblock0)
mtd_master0
- With partition and MTD_PARTITIONED_MASTER=y
mtd0 (mtd0ro mtdblock0) [this is the master]
mtd1 (mtd1ro mtdblock1)
mtd_master0 -> link to mtd0
What do you think? Or maybe even always mtd_master in the first place.
Richard, your point of view on this?
Thanks,
Miquèl
Powered by blists - more mailing lists