linux-kernel - Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250402172659.59df72d2.pasic@linux.ibm.com>
Date: Wed, 2 Apr 2025 17:26:59 +0200
From: Halil Pasic <pasic@...ux.ibm.com>
To: Amit Shah <amit@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>,
        virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, "Michael S. Tsirkin"
 <mst@...hat.com>
Cc: stable@...r.kernel.org,
        "Maximilian Immanuel Brandtner"
 <maxbr@...ux.ibm.com>,
        Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH 1/1] virtio_console: fix missing byte order handling for
 cols and rows

On Sat, 22 Mar 2025 01:29:54 +0100
Halil Pasic <pasic@...ux.ibm.com> wrote:

> As per virtio spec the fields cols and rows are specified as little
> endian. 
[..]

@Amit: Any feedback?

> 
> Fixes: 8345adbf96fc1 ("virtio: console: Accept console size along with resize control message")
> Signed-off-by: Halil Pasic <pasic@...ux.ibm.com>
> Cc: stable@...r.kernel.org # v2.6.35+
> ---
> 
> @Michael: I think it would be nice to add a clarification on the byte
> order to be used for cols and rows when the legacy interface is used to
> the spec, regardless of what we decide the right byte order is. If
> it is native endian that shall be stated much like it is stated for
> virtio_console_control. If it is little endian, I would like to add
> a sentence that states that unlike for the fields of virtio_console_control
> the byte order of the fields of struct virtio_console_resize is little
> endian also when the legacy interface is used.

@MST: any opinion on that?

[..]