linux-kernel - Re: [PATCH] media: mediatek: vcodec: Correct vsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fe576366e52d530d0507d8475fb52210a27b6df.camel@ndufresne.ca>
Date: Wed, 02 Apr 2025 11:34:57 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Fei Shao <fshao@...omium.org>, Hans Verkuil <hverkuil@...all.nl>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>, Yunfei Dong
	 <yunfei.dong@...iatek.com>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] media: mediatek: vcodec: Correct vsi_core framebuffer
 size

Hi,

Le vendredi 14 mars 2025 à 15:56 +0800, Fei Shao a écrit :
> The framebuffer size for decoder instances was being incorrectly set -
> inst->vsi_core->fb.y.size was assigned twice consecutively.
> 
> Assign the second picinfo framebuffer size to the C framebuffer instead,
> which appears to be the intended target based on the surrounding code.
> 
> Fixes: 2674486aac7d ("media: mediatek: vcodec: support stateless hevc decoder")
> Signed-off-by: Fei Shao <fshao@...omium.org>
> ---
> 
>  .../mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> index aa721cc43647..2725db882e5b 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> @@ -821,7 +821,7 @@ static int vdec_hevc_slice_setup_core_buffer(struct vdec_hevc_slice_inst *inst,
>  	inst->vsi_core->fb.y.dma_addr = y_fb_dma;
>  	inst->vsi_core->fb.y.size = ctx->picinfo.fb_sz[0];
>  	inst->vsi_core->fb.c.dma_addr = c_fb_dma;
> -	inst->vsi_core->fb.y.size = ctx->picinfo.fb_sz[1];
> +	inst->vsi_core->fb.c.size = ctx->picinfo.fb_sz[1];

To Yunfei, this information is copied to be passed to the CORE, is that
value not used by the firmware ? I can see that everything else in the
driver uses the picinfo structure. I'm simply trying to understand why
that didn't break anything and what is the implication before this fix,
so I can determin is that's more or less cosmetic at the moment. That
being asked, I'll give it my:

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

>  
>  	inst->vsi_core->dec.vdec_fb_va = (unsigned long)fb;
>