linux-kernel - Re: [RFC PATCH 1/3] content: Add VIRTIO_F_SWIOTLB to negotiate use of SWIOTLB bounce buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaef09ab218900a53347987a62fee1787283d9ed.camel@infradead.org>
Date: Wed, 02 Apr 2025 18:10:53 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: virtio-comment@...ts.linux.dev, hch@...radead.org, Claire Chang
 <tientzu@...omium.org>, linux-devicetree <devicetree@...r.kernel.org>, Rob
 Herring <robh+dt@...nel.org>, Jörg Roedel
 <joro@...tes.org>,  iommu@...ts.linux-foundation.org,
 linux-kernel@...r.kernel.org, graf@...zon.de
Subject: Re: [RFC PATCH 1/3] content: Add VIRTIO_F_SWIOTLB to negotiate use
 of SWIOTLB bounce buffers

On Wed, 2025-04-02 at 12:43 -0400, Michael S. Tsirkin wrote:
> 
> yes.
> 
> I know a bit more about PCI, and for PCI I prefer just not saying
> anything. The platform already defines whether it is behind an iommu
> or not, and duplication is not good.

Not a hill for me to die on I suppose, but I would personally prefer to
spell it out in words of one syllable or fewer, to make *sure* that
device and driver authors get it right even though it's "obvious".

After all, if we could trust them to do their thinking, we would never
have had the awful situation that led to VIRTIO_F_ACCESS_PLATFORM
existing in the first place; the legacy behaviour we get when that bit
*isn't* set would never have happened.

> For mmio it is my understanding that the "restricted" does the same
> already? or is it required in the spec for some reason?

No, it's exactly the same. But I still don't trust driver authors to
realise the obvious, or VMM implementations either for that matter.

I'm not sure I see the *harm* in spelling out explicitly for the hard-
of-thinking.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5069 bytes)