linux-kernel - Re: [GIT PULL] more printk for 6.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgfX9nBGE0Ap9GjhOy7Mn=RSy=rx0MvqfYFFDx31KJXqQ@mail.gmail.com>
Date: Wed, 2 Apr 2025 10:12:27 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>, Steven Rostedt <rostedt@...dmis.org>, 
	John Ogness <john.ogness@...utronix.de>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, Peter Zijlstra <peterz@...radead.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] more printk for 6.15

On Wed, 2 Apr 2025 at 05:58, Petr Mladek <pmladek@...e.com> wrote:
>
> please pull few more printk-related changes from

Pulled. However, I reacted to this mess:

  +#pragma GCC diagnostic push
  +#ifndef __clang__
  +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
  +#endif

do we really need a "#ifndef __clang__" there? It's "#pragma GCC"
after all, and the diagnostic push/pop are done unconditionally.

I can well imagine that yes, we need it for some strange and stupid
reason, but it looks wrong, and the commit message doesn't explain why
we'd need it.

And once again the "Link" is completely useless and doesn't point to
any explanation, only points to the submission that has all the same
info.

I hate those things. The disappointment is real: "Oh, an explanation"
followed by "No, just useless noise, doing a google search would
almost certainly have been more productive".

              Linus